hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7241) Merge YARN-5734 to trunk/branch-2
Date Mon, 25 Sep 2017 17:52:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179430#comment-16179430
] 

Wangda Tan commented on YARN-7241:
----------------------------------

1) for CLI: {{schedconf}} => {{scheduler-conf}}
- Need to change yarn/yarn.cmd, also {{SchedConfCLI#printUsage}}

2) SchedConfCLI
- Annotation: {{Evolving}} => {{Unstable}}
- In the {{printUsage}}, please note that this is an alpha feature, all options could be changed
in the future and do not use it in production.
- Do you think is it better to use ":" to separate queues and their parameters, such as: 
{code}
-add root.a:capacity=10,user-limit=50;root.b...
-update root.a:capacity=10 ...
{code}
- To make it consistent, it's better to use ";" to separate queues in {{-remove}}
- Also, please give some example in the printUsage:
{code}
231     System.out.println("yarn schedconf [-add queueAddPath1,confKey1=confVal1,"
232         + "confKey2=confVal2;queueAddPath2,confKey3=confVal3] "
233         + "[-remove queueRemovePath1,queueRemovePath2] "
234         + "[-update queueUpdatePath1,confKey1=confVal1] "
235         + "[-global globalConfKey1=globalConfVal1,"
236         + "globalConfKey2=globalConfVal2]");
{code}
It is too abstract for people to understand. (Example like {{-add root.a:capacity=100}})
- You may need to update YarnCommands.md as well.

3) Configurations:
- It looks like we may not need to add anything to CapacitySchedulerConfiguration. {{CS_CONF_PROVIDER}}
can be replaced by {{SCHEDULER_CONFIGURATION_STORE_CLASS}}, correct?
- Also, please mark all new added {{public static final String}} in YarnConfiguration to {{@Private/@Unstable}}.
- Inside yarn-default.xml:
Please add a note to {{yarn.scheduler.configuration.store.class}}, it only take effect when
scheduler support mutable conf, and please add note that currently only CapacityScheduler
supports mutable conf.
- "Memory" should not be a default option value, we should put "zk" as default. (Need to change
CapacityScheduler.md)

4) Rest endpoint: 
- {{/sched-conf}} => {{/scheduler-conf}}


> Merge YARN-5734 to trunk/branch-2
> ---------------------------------
>
>                 Key: YARN-7241
>                 URL: https://issues.apache.org/jira/browse/YARN-7241
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>         Attachments: YARN-7241.001.patch
>
>
> Ticket for jenkins pre-commit for full diff.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message