hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7202) End-to-end UT for api-server
Date Tue, 26 Sep 2017 22:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181680#comment-16181680
] 

Jian He commented on YARN-7202:
-------------------------------

[~eyang], thanks for working on the patch.
I looked at the patch, looks like the test only check whether the return code is success or
failure. I think it can be more end-to-end, i.e.  a fully functional rest API test, e.g. from
the submission till the persistency of service config file. TestServiceCLI does that from
CLI level.  Also, the mockServiceClient pretty much hides all the real code, making it work
with real ServiceClient will be testing the real code.
Btw, there are a bunch RM web service related tests in the codebase. e.g TestRMWebServicesAppsModification,
TestRMWebServices etc.  Those tests actually test it from end-to-end without mock code



> End-to-end UT for api-server
> ----------------------------
>
>                 Key: YARN-7202
>                 URL: https://issues.apache.org/jira/browse/YARN-7202
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Eric Yang
>         Attachments: YARN-7202.yarn-native-services.001.patch, YARN-7202.yarn-native-services.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message