hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billie Rinaldi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7186) Add examples in yarn-service
Date Tue, 12 Sep 2017 19:27:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163522#comment-16163522
] 

Billie Rinaldi commented on YARN-7186:
--------------------------------------

bq. I now think [service-name] can be optional, because for trying the example service, we
need a way for user to explicitly specify the name to avoid name collision.
Yes, it is not very convenient having the name specified in the json, because it makes it
harder to reuse the json. Adding back an optional service name for the create command that
would override the name specified in the json would be a reasonable way to mitigate this issue.

bq. this may be ambiguous, if we have a sleeper.json under current working dir
That's why I suggested that we check the current working directory first, and if the file
doesn't exist there, then check the examples directory. If we go this route, we should log
the path that we load successfully. If this seems too complicated, introducing an --example
option would be okay, as long as we make it clear that --example and --file can't be used
together. I strongly think we should not call the option --type or --kind, as that is too
generic and sounds like it means the type of service or the type of file that would be loaded.
Naming it --example would be okay.


> Add examples in yarn-service 
> -----------------------------
>
>                 Key: YARN-7186
>                 URL: https://issues.apache.org/jira/browse/YARN-7186
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-7186.yarn-native-services.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message