hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7162) Remove XML excludes file format
Date Thu, 14 Sep 2017 21:59:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167021#comment-16167021
] 

Robert Kanter commented on YARN-7162:
-------------------------------------

It would be better if we had the pluggable JSON support (i.e. YARN-5536), but it seems like
nobody has the time to work on that before beta 1.  As I said before, the concern here is
that if we make a release with the XML format, we're going to have to keep supporting that
format for the lifetime of Hadoop 3.  Maybe we do want to support the old format, JSON, and
XML, but we _may_ need to tweak the XML format incompatibly depending on how the JSON format
ends up and how the pluggable code for it works; but we'd be stuck if we make a release with
the existing XML in that case.  Or maybe once we have the JSON format we don't want to worry
about the XML format.  In any case, the safest thing to do is to remove the XML format now
before the release; we can always add XML back later using the pluggable framework as part
of YARN-5536.  In other words, keeping it isn't necessarily a backwards incompatible change,
but keeping it runs the risk of a potential backwards incompatible change in the future, especially
given that we're planning on rewriting it.

[~mingma] actually voted for removing the XML format for now:
{quote}Sorry for the delayed response. I have been busy and won't have time to look into.
I vote for 2nd option.{quote}
{quote}
2. We could remove the XML format now (so we'd only have the original format), and do the
rest of this work later. Users won't be able to specify individual different timeouts per
host in the meantime though.
{quote}

> Remove XML excludes file format
> -------------------------------
>
>                 Key: YARN-7162
>                 URL: https://issues.apache.org/jira/browse/YARN-7162
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: graceful
>    Affects Versions: 2.9.0, 3.0.0-beta1
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Blocker
>         Attachments: YARN-7162.001.patch, YARN-7162.branch-2.001.patch
>
>
> YARN-5536 aims to replace the XML format for the excludes file with a JSON format.  However,
it looks like we won't have time for that for Hadoop 3 Beta 1.  The concern is that if we
release it as-is, we'll now have to support the XML format as-is for all of Hadoop 3.x, which
we're either planning on removing, or rewriting using a pluggable framework.  
> [This comment in YARN-5536|https://issues.apache.org/jira/browse/YARN-5536?focusedCommentId=16126194&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16126194]
proposed two quick solutions to prevent this compat issue.  In this JIRA, we're going to remove
the XML format.  If we later want to add it back in, YARN-5536 can add it back, rewriting
it to be in the pluggable framework.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message