hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7072) Add a new log aggregation file format controller
Date Fri, 08 Sep 2017 08:41:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158305#comment-16158305
] 

Junping Du commented on YARN-7072:
----------------------------------

Patch LGTM in overall. The findbug warning is not related. However two javadoc errors should
get fixed:
{code}
...
[ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/ContainerLogMeta.java:29:
error: reference not found
[ERROR] *   <li>A list of {@link PerContainerLogFileInfo}.</li>
[ERROR] ^
...
[ERROR] /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/ContainerLogsInfo.java:37:
error: reference not found
[ERROR] *   <li>A list of {@link PerContainerLogFileInfo}.</li>
[ERROR] ^
{code}

Will +1 after javadoc warnings get fixed. Some NITs could get fixed later in other following
JIRAs.

> Add a new log aggregation file format controller
> ------------------------------------------------
>
>                 Key: YARN-7072
>                 URL: https://issues.apache.org/jira/browse/YARN-7072
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-7072-trunk.001.patch, YARN-7072.trunk.002.patch, YARN-7072-trunk.003.patch,
YARN-7072-trunk.004.patch, YARN-7072-trunk.005.patch, YARN-7072-trunk.006.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message