hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7023) Incorrect ReservationId.compareTo() implementation
Date Fri, 01 Sep 2017 20:08:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151083#comment-16151083
] 

Hudson commented on YARN-7023:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12303 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12303/])
YARN-7023. Incorrect ReservationId.compareTo() implementation. (aajisaka: rev c5281a85e108c7cab6e84dfe351843483d720b9b)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ReservationId.java


> Incorrect ReservationId.compareTo() implementation
> --------------------------------------------------
>
>                 Key: YARN-7023
>                 URL: https://issues.apache.org/jira/browse/YARN-7023
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: reservation system
>    Affects Versions: 2.6.0, 3.0.0-alpha1
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Minor
>             Fix For: 2.9.0, 3.0.0-beta1, 2.8.2, 3.1.0
>
>         Attachments: YARN-7023.1.patch, YARN-7023.patch
>
>
> Obviously this is a typo and the second getId() call should be rewritten as 'other.getId()'
> +Lines 94-102+
> {code:java}
>   @Override
>   public int compareTo(ReservationId other) {
>     if (this.getClusterTimestamp() - other.getClusterTimestamp() == 0) {
>       return getId() > getId() ? 1 : getId() < getId() ? -1 : 0;
>     } else {
>       return this.getClusterTimestamp() > other.getClusterTimestamp() ? 1
>           : this.getClusterTimestamp() < other.getClusterTimestamp() ? -1 : 0;
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message