hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sen Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7001) If shared cache upload is terminated in the middle, the temp file will never be deleted
Date Wed, 20 Sep 2017 02:38:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172642#comment-16172642
] 

Sen Zhao commented on YARN-7001:
--------------------------------

[~miklos.szegedi@cloudera.com], I add a unit test in this patch. Could you review it? 

> If shared cache upload is terminated in the middle, the temp file will never be deleted
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-7001
>                 URL: https://issues.apache.org/jira/browse/YARN-7001
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Sen Zhao
>         Attachments: YARN-7001.001.patch, YARN-7001.002.patch
>
>
> There is a missing deleteTempFile(tempPath);
> {code}
>       tempPath = new Path(directoryPath, getTemporaryFileName(actualPath));
>       if (!uploadFile(actualPath, tempPath)) {
>         LOG.warn("Could not copy the file to the shared cache at " + tempPath);
>         return false;
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message