hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-6968) Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
Date Wed, 20 Sep 2017 18:20:00 GMT

     [ https://issues.apache.org/jira/browse/YARN-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eric Badger updated YARN-6968:
------------------------------
    Attachment: YARN-6968.003.patch

Hey [~miklos.szegedi@cloudera.com], thanks for the review. I'm attaching a new patch that
addresses your comments.

bq. Is there a reason to duplicate the configuration? We could use yarn.nodemanager.linux-container-executor.cgroups.mount-path
or even better we could get the value from CGroupsHandler, so that it is auto detected.
Yea I suppose that is a better way to do this. Adding a new getter method for the cgroups
root directory that we can get from the CGroupsHandler. 

bq. The path inside the container could be configurable separately indeed, however it is probably
a good idea to make it configurable by the client.
This may have security ramifications given that we're allowing the user to potentially overwrite
directories in the container with the cgroups directory. Not quite sure how this could be
leveraged, but it gives the user input into how their container is set up, which generally
degrades security. Either way though, this would be something to do in a follow-up jira, not
here. In this JIRA we just want that pesky findbugs warning to go away. 

bq. Also, it is interesting that the findbugs warning did not go away with the patch.
It actually did get rid of it. It just also shows it during the trunk compilation, not during
the patch compilation. In the patch compilation, you can see it show that it got rid of the
warning

{noformat}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated
0 new + 0 unchanged - 1 fixed = 0 total (was 1)
{noformat}

> Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6968
>                 URL: https://issues.apache.org/jira/browse/YARN-6968
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Miklos Szegedi
>            Assignee: Eric Badger
>         Attachments: YARN-6968.001.patch, YARN-6968.002.patch, YARN-6968.003.patch
>
>
> This could be done after YARN-6757 is checked in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message