hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6968) Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
Date Wed, 20 Sep 2017 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173337#comment-16173337
] 

Miklos Szegedi commented on YARN-6968:
--------------------------------------

Thank you, [~ebadger] for working on this and submitting the patch. Is there a reason to duplicate
the configuration? We could use yarn.nodemanager.linux-container-executor.cgroups.mount-path
or even better we could get the value from CGroupsHandler, so that it is auto detected. The
path inside the container could be configurable separately indeed, however it is probably
a good idea to make it configurable by the client. Also, it is interesting that the findbugs
warning did not go away with the patch.

> Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6968
>                 URL: https://issues.apache.org/jira/browse/YARN-6968
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Miklos Szegedi
>            Assignee: Eric Badger
>         Attachments: YARN-6968.001.patch, YARN-6968.002.patch
>
>
> This could be done after YARN-6757 is checked in.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message