hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6296) ReservationId.compareTo ignores id when clustertimestamp is the same
Date Thu, 28 Sep 2017 21:22:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184903#comment-16184903
] 

Hadoop QA commented on YARN-6296:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} | {color:red}
YARN-6296 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-6296 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12876614/YARN-6296.001.patch
|
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/17687/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> ReservationId.compareTo ignores id when clustertimestamp is the same
> --------------------------------------------------------------------
>
>                 Key: YARN-6296
>                 URL: https://issues.apache.org/jira/browse/YARN-6296
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Haibo Chen
>              Labels: newbie
>         Attachments: YARN-6296.001.patch
>
>
> Per YARN-6252
> {code:java}
>   public int compareTo(ReservationId other) {
>     if (this.getClusterTimestamp() - other.getClusterTimestamp() == 0) {
>       return getId() > getId() ? 1 : getId() < getId() ? -1 : 0;
>     } else {
>     }
>   }
> {code}
> compares id with itself. It should be
> {code}
> return this.getId() > other.getId() ? 1 : (this.getId() < other.getId() ? -1 :
0);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message