Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 24 Aug 2017 14:55:00 +0000 (UTC)
From: "Billie Rinaldi (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13097205.1503551797000.111991.1503586500560@Atlassian.JIRA>
In-Reply-To: <JIRA.13097205.1503551797000@Atlassian.JIRA>
References: <JIRA.13097205.1503551797000@Atlassian.JIRA> <JIRA.13097205.1503551797172@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-7091) Rename application to service in
 yarn-native-services
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 24 Aug 2017 14:55:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-7091?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16140=
119#comment-16140119 ]=20

Billie Rinaldi commented on YARN-7091:
--------------------------------------

[~jianhe], I am very happy about the effects of these changes. I think stan=
dardizing on the name "service" in yarn-native-services will really clarify=
 our terminology. A few comments on patch 01:
* regarding hadoop-yarn-services-core, are other modules planned under hado=
op-yarn-services? If not, we could combine these into a single module
* change YARN_SERVICESAPI_OPTS in yarn-env.sh to YARN_APISERVER_OPTS
* change deleteApplication / updateApplication log statements to delete ser=
vice / update service in ApplicationApiService. Also, the variable name upd=
ateAppData should be changed (I am not as concerned about the variable appN=
ame, since it=E2=80=99s also the YARN app name)
* rename ApplicationApiService and ApplicationApiWebApp to ApiServer and Ap=
iWebApp or ApiServerWebApp
* in the yaml, check for usages of =E2=80=9Can service=E2=80=9D -- it shoul=
d be =E2=80=9Ca service.=E2=80=9D For =E2=80=9CGet an service details=E2=80=
=9D just remove =E2=80=9Can.=E2=80=9D Check for uses of =E2=80=9Capp=E2=80=
=9D -- =E2=80=9Capp-component=E2=80=9D should be =E2=80=9Ccomponent,=E2=80=
=9D other usages of =E2=80=9Capp=E2=80=9D should change to =E2=80=9Cservice=
=E2=80=9D (but look out for =E2=80=9Can app=E2=80=9D) -- except webapp whic=
h is fine. The API records java classes have the same issues (since they ar=
e generated from the yaml)
* (unrelated) in the yaml, we should mention the format reqs for component =
name and service name
* rename ServiceApiUtil methods with =E2=80=9Capplication=E2=80=9D in the n=
ame (loadApplication, validateAndResolveApplication, etc.)
* ActionListArgs and SliderActions have =E2=80=9Can service=E2=80=9D
* there are some git artifacts in the patch - ContainerState.java~HEAD, Con=
tainerState.java~HEAD_0, and a couple other versions of ContainerState

> Rename application to service in yarn-native-services
> -----------------------------------------------------
>
>                 Key: YARN-7091
>                 URL: https://issues.apache.org/jira/browse/YARN-7091
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-7091.yarn-native-services.01.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org