Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CEFF3200D08 for ; Wed, 23 Aug 2017 00:49:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CD7C0167C47; Tue, 22 Aug 2017 22:49:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2761E167C44 for ; Wed, 23 Aug 2017 00:49:07 +0200 (CEST) Received: (qmail 86883 invoked by uid 500); 22 Aug 2017 22:49:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 86872 invoked by uid 99); 22 Aug 2017 22:49:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 22:49:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D7B7C1A090F for ; Tue, 22 Aug 2017 22:49:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UHJa5H2409Fj for ; Tue, 22 Aug 2017 22:49:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C6CD261835 for ; Tue, 22 Aug 2017 22:49:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A8818E059C for ; Tue, 22 Aug 2017 22:49:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C886425382 for ; Tue, 22 Aug 2017 22:49:00 +0000 (UTC) Date: Tue, 22 Aug 2017 22:49:00 +0000 (UTC) From: "Subru Krishnan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7053) Move curator transaction support to ZKCuratorManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 22 Aug 2017 22:49:08 -0000 [ https://issues.apache.org/jira/browse/YARN-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137546#comment-16137546 ] Subru Krishnan commented on YARN-7053: -------------------------------------- Thanks [~jhung] for updating the patch. Let's look at how the tests go for v4. We do *not* need fencing in {{ZookeeperFederationStateStore}} as we rely on RM for that. That's why after looking at the code I wanted to skip this. So you'll have to revert the changes to {{ZookeeperFederationStateStore}} (sorry). In {{TestZKCuratorManager::testTransaction}}, this should be false after deletion right? {quote} assertTrue(Arrays.equals(setData, curator.getData(node1)));{quote} > Move curator transaction support to ZKCuratorManager > ---------------------------------------------------- > > Key: YARN-7053 > URL: https://issues.apache.org/jira/browse/YARN-7053 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Jonathan Hung > Assignee: Jonathan Hung > Attachments: YARN-7053.001.patch, YARN-7053.002.patch, YARN-7053.003.patch, YARN-7053.004.patch > > > HADOOP-14741 moves curator functionality to ZKCuratorManager. ZKRMStateStore has some curator transaction support which can be reused, so this can be moved to ZKCuratorManager as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org