Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 58E812004A0 for ; Wed, 16 Aug 2017 14:24:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5799816896C; Wed, 16 Aug 2017 12:24:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9E505168963 for ; Wed, 16 Aug 2017 14:24:03 +0200 (CEST) Received: (qmail 58668 invoked by uid 500); 16 Aug 2017 12:24:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 58657 invoked by uid 99); 16 Aug 2017 12:24:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 12:24:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EBF4A1A03F2 for ; Wed, 16 Aug 2017 12:24:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Gdps8RtotrNn for ; Wed, 16 Aug 2017 12:24:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0FE565F6BF for ; Wed, 16 Aug 2017 12:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 97293E08C6 for ; Wed, 16 Aug 2017 12:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 52EEB2537E for ; Wed, 16 Aug 2017 12:24:00 +0000 (UTC) Date: Wed, 16 Aug 2017 12:24:00 +0000 (UTC) From: "Oleg Danilov (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-7023) Incorrect ReservationId.compareTo() implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 16 Aug 2017 12:24:04 -0000 [ https://issues.apache.org/jira/browse/YARN-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Danilov updated YARN-7023: ------------------------------- Attachment: YARN-7023.patch > Incorrect ReservationId.compareTo() implementation > -------------------------------------------------- > > Key: YARN-7023 > URL: https://issues.apache.org/jira/browse/YARN-7023 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Oleg Danilov > Priority: Minor > Attachments: YARN-7023.patch > > > Obviously this is a typo and the second getId() call should be rewritten as 'other.getId()' > +Lines 94-102+ > {code:java} > @Override > public int compareTo(ReservationId other) { > if (this.getClusterTimestamp() - other.getClusterTimestamp() == 0) { > return getId() > getId() ? 1 : getId() < getId() ? -1 : 0; > } else { > return this.getClusterTimestamp() > other.getClusterTimestamp() ? 1 > : this.getClusterTimestamp() < other.getClusterTimestamp() ? -1 : 0; > } > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org