Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1B8A9200CE3 for ; Sun, 13 Aug 2017 14:08:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1864C16454A; Sun, 13 Aug 2017 12:08:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5CF19164543 for ; Sun, 13 Aug 2017 14:08:06 +0200 (CEST) Received: (qmail 27341 invoked by uid 500); 13 Aug 2017 12:08:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 27329 invoked by uid 99); 13 Aug 2017 12:08:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Aug 2017 12:08:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E48B1180773 for ; Sun, 13 Aug 2017 12:08:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PPu1OKJjexV7 for ; Sun, 13 Aug 2017 12:08:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 166A960D92 for ; Sun, 13 Aug 2017 12:08:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 45BB8E099C for ; Sun, 13 Aug 2017 12:08:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id ECF9A218FA for ; Sun, 13 Aug 2017 12:08:00 +0000 (UTC) Date: Sun, 13 Aug 2017 12:08:00 +0000 (UTC) From: "Manikandan R (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (YARN-6982) Potential issue on setting AMContainerSpec#tokenConf to null before app is completed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 13 Aug 2017 12:08:07 -0000 [ https://issues.apache.org/jira/browse/YARN-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124901#comment-16124901 ] Manikandan R edited comment on YARN-6982 at 8/13/17 12:07 PM: -------------------------------------------------------------- [~rohithsharma] Thanks for review and filing this. As this is related to YARN-65 and almost nearing completion, I am assigning this JIRA to myself. Please re-assign if someone is already working on it. was (Author: manirajv06@gmail.com): [~rohithsharma] Thanks for review and filing this. As this is related to YARN-65 and almost nearing completion, I assigning this to myself. Please re-assign if someone is already working on it. > Potential issue on setting AMContainerSpec#tokenConf to null before app is completed > ------------------------------------------------------------------------------------ > > Key: YARN-6982 > URL: https://issues.apache.org/jira/browse/YARN-6982 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Rohith Sharma K S > > While reviewing patch for YARN-65, I found that many places RMAppImpl#submissionContext sets containerLaunchcontext#setTokensConf has been set to null i.e > {code} > // set the memory free > app.submissionContext.getAMContainerSpec().setTokensConf(null); > {code} > This appears be a issue if application is updated may be because queue move or lifetime or priority, then submission context will be restored again into state store. Consider after app update, if RM is restarted then submission context will have null tokenConf. This could be a potential issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org