Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 29 Aug 2017 10:18:01 +0000 (UTC)
From: "Rohith Sharma K S (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13093763.1502368315000.144983.1504001881698@Atlassian.JIRA>
In-Reply-To: <JIRA.13093763.1502368315000@Atlassian.JIRA>
References: <JIRA.13093763.1502368315000@Atlassian.JIRA> <JIRA.13093763.1502368315407@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-6982) Potential issue on setting
 AMContainerSpec#tokenConf to null before app is completed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 29 Aug 2017 10:18:13 -0000


    [ https://issues.apache.org/jira/browse/YARN-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145065#comment-16145065 ] 

Rohith Sharma K S commented on YARN-6982:
-----------------------------------------

thanks [~manirajv06@gmail.com] for the patch! 
+1 lgtm. Would you mind taking a look at the failed tests?

> Potential issue on setting AMContainerSpec#tokenConf to null before app is completed
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-6982
>                 URL: https://issues.apache.org/jira/browse/YARN-6982
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Rohith Sharma K S
>            Assignee: Manikandan R
>         Attachments: YARN-6982.001.patch
>
>
> While reviewing patch for YARN-65, I found that many places RMAppImpl#submissionContext sets containerLaunchcontext#setTokensConf has been set to null i.e 
> {code}
> // set the memory free
> app.submissionContext.getAMContainerSpec().setTokensConf(null);
> {code}
> This appears be a issue if application is updated may be because queue move or lifetime or priority, then submission context will be restored again into state store. Consider after app update, if RM is restarted then submission context will have null tokenConf. This could be a potential issue. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org