Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1D2F22004F5 for ; Sat, 12 Aug 2017 00:05:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1B54016E1C6; Fri, 11 Aug 2017 22:05:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6013916E1A0 for ; Sat, 12 Aug 2017 00:05:05 +0200 (CEST) Received: (qmail 88933 invoked by uid 500); 11 Aug 2017 22:05:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 88829 invoked by uid 99); 11 Aug 2017 22:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 22:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6B6FD18081D for ; Fri, 11 Aug 2017 22:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Np_IZK9zo8qH for ; Fri, 11 Aug 2017 22:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8C8A05FD6F for ; Fri, 11 Aug 2017 22:05:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C98F6E0D71 for ; Fri, 11 Aug 2017 22:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CC3EE241C5 for ; Fri, 11 Aug 2017 22:05:00 +0000 (UTC) Date: Fri, 11 Aug 2017 22:05:00 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6967) Limit application attempt's diagnostic message size thoroughly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 11 Aug 2017 22:05:06 -0000 [ https://issues.apache.org/jira/browse/YARN-6967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124168#comment-16124168 ] Hudson commented on YARN-6967: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12170 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12170/]) YARN-6967. Limit application attempt's diagnostic message size (templedf: rev 65364defb4a633ca20b39ebc38cd9c0db63a5835) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java > Limit application attempt's diagnostic message size thoroughly > -------------------------------------------------------------- > > Key: YARN-6967 > URL: https://issues.apache.org/jira/browse/YARN-6967 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.8.1 > Reporter: Chengbing Liu > Assignee: Chengbing Liu > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: YARN-6967.01.patch > > > YARN-6125 implemented {{BoundedAppender}} and applied to the field {{diagnostics}} to limit the diagnostic message's size. > However, some code bypasses this limit. In {{RMAppAttemptImpl.rememberTargetTransitionsAndStoreState(...)}}, a local variable {{diags}} will finally be written into ZooKeeper if ZKRMStateStore is used. > A simple fix is to also use {{BoundedAppender}} for the local variable. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org