Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 15 Aug 2017 17:22:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13085800.1499634301000.35225.1502817720272@Atlassian.JIRA>
In-Reply-To: <JIRA.13085800.1499634301000@Atlassian.JIRA>
References: <JIRA.13085800.1499634301000@Atlassian.JIRA> <JIRA.13085800.1499634301134@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-6781)
 ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 15 Aug 2017 17:22:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127568#comment-16127568 ] 

Hadoop QA commented on YARN-6781:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m 21s{color} | {color:red} YARN-6781 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-6781 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12881972/YARN-6781.001.patch |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/16910/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.


> ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter
> -------------------------------------------------------------------------
>
>                 Key: YARN-6781
>                 URL: https://issues.apache.org/jira/browse/YARN-6781
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Yu-Tang Lin
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6781.001.patch
>
>
> The {{resourceInformationMap}} parameter is always passed in as a new {{Map}} object, and it's never referenced again after the call.  The parameter can be eliminated.  Instead the {{Map}} can be created inside the {{initializeResourcesMap()}} method.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org