hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7113) Clean up packaging and dependencies for yarn-native-services
Date Tue, 29 Aug 2017 07:14:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144851#comment-16144851
] 

Jian He commented on YARN-7113:
-------------------------------

bq. I'm not sure what you mean. Patch 01 renames src/main/resources/webapps/services-rest-api/app
to src/main/resources/webapps/api-server/app, 
Sorry, I was using the 'patch' command instead of "git apply" command. And patch command doesn't
recognize the rename of the file. So, the file was not renamed when I tested.
Btw, why is the exclusion of objenesis ?
{code}
    <dependency>
      <groupId>org.easymock</groupId>
      <artifactId>easymock</artifactId>
      <version>3.1</version>
      <exclusions>
        <exclusion>
          <groupId>org.objenesis</groupId>
          <artifactId>objenesis</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
{code}
For the easymock, do you think it's worth to change the test case to use Mockito ? It's TestServiceApi,
TestAppJsonResolve, and TestLoadExampleAppJson. That way, we can remove the dependency for
easymock. But, I'm also fine to keep as-is, just want to hear your opinion. 


> Clean up packaging and dependencies for yarn-native-services
> ------------------------------------------------------------
>
>                 Key: YARN-7113
>                 URL: https://issues.apache.org/jira/browse/YARN-7113
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-native-services
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: yarn-native-services
>
>         Attachments: diff.patch, YARN-7113-yarn-native-services.01.patch, YARN-7113-yarn-native-services.02.patch
>
>
> Since the yarn native services code has been greatly simplified, I think we no longer
need a separate lib directory for services. A dependency cleanup is needed to address unused
declared dependencies and used undeclared dependencies in the new modules. We should also
address NOTICE changes needed for the 3 new dependencies that are being added, jcommander,
snakeyaml, and swagger-annotations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message