hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6967) Limit application attempt's diagnostic message size thoroughly
Date Tue, 08 Aug 2017 15:59:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118522#comment-16118522
] 

Daniel Templeton commented on YARN-6967:
----------------------------------------

Thanks for catching that, [~chengbing.liu].  In the original code the diags string is only
set, never appended to.  In the patch, you're only appending.  Seems like that might change
the diag messages and tend to make them longer on average (though never longer than the limit).

> Limit application attempt's diagnostic message size thoroughly
> --------------------------------------------------------------
>
>                 Key: YARN-6967
>                 URL: https://issues.apache.org/jira/browse/YARN-6967
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.8.1
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>         Attachments: YARN-6967.01.patch
>
>
> YARN-6125 implemented {{BoundedAppender}} and applied to the field {{diagnostics}} to
limit the diagnostic message's size.
> However, some code bypasses this limit. In {{RMAppAttemptImpl.rememberTargetTransitionsAndStoreState(...)}},
a local variable {{diags}} will finally be written into ZooKeeper if ZKRMStateStore is used.
> A simple fix is to also use {{BoundedAppender}} for the local variable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message