hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work
Date Fri, 18 Aug 2017 15:43:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133145#comment-16133145
] 

Sunil G commented on YARN-6933:
-------------------------------

Latest patch seems fine to me. May be exception message in {{checkMandatoryResources}} could
be improved given there is a new patch. I will wait for [~templedf] also to take a look.

> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating
work
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-6933
>                 URL: https://issues.apache.org/jira/browse/YARN-6933
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>              Labels: newbie++
>         Attachments: YARN-6933-YARN-3926.001.patch, YARN-6933-YARN-3926.002.patch, YARN-6933-YARN-3926.003.patch,
YARN-6933-YARN-3926.004.patch
>
>
> Both are used to check that the mandatory resources were not redefined.  Only one check
is needed.  I would recommend dropping {{DISALLOWED_RESOURCES}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message