hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manikandan R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6933) ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating work
Date Tue, 29 Aug 2017 09:23:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144977#comment-16144977

Manikandan R commented on YARN-6933:

[~daniel@cloudera.com] Attaching a new patch with the changes. New message would be slightly
different from others as 'memory' check is different from 'memory-mb' & 'vcores' checks.
I think throwing the same exception message would make some confusions to end users?. Thoughts?
In addition, logging a warn message as well

> ResourceUtils.DISALLOWED_NAMES and ResourceUtils.checkMandatoryResources() are duplicating
> -----------------------------------------------------------------------------------------------
>                 Key: YARN-6933
>                 URL: https://issues.apache.org/jira/browse/YARN-6933
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>              Labels: newbie++
>         Attachments: YARN-6933-YARN-3926.001.patch, YARN-6933-YARN-3926.002.patch, YARN-6933-YARN-3926.003.patch,
YARN-6933-YARN-3926.004.patch, YARN-6933-YARN-3926.005.patch, YARN-6933-YARN-3926.006.patch,
YARN-6933-YARN-3926.007.patch, YARN-6933-YARN-3926.008.patch
> Both are used to check that the mandatory resources were not redefined.  Only one check
is needed.  I would recommend dropping {{DISALLOWED_RESOURCES}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message