hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Kumpf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6930) Admins should be able to explicitly enable specific LinuxContainerRuntime in the NodeManager
Date Thu, 17 Aug 2017 12:16:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130317#comment-16130317

Shane Kumpf commented on YARN-6930:

Thanks for the review, [~ebadger].

The findbugs isn't related to this JIRA, butI think it's something that we should fix.
See YARN-6515. YARN-6968 has been created to track fixing the issue, but I expect we'll remove
the reference all together once whitelisted mounts are available.

Is it ok to import static variables one by one or should we just import YarnConfiguration
and reference the variables specifically?
Given line length limits and how long some of the config options have become, IMO, it improves
readability, but I'll let others comment if there is a strong opinion.

I also wonder whether it would be better/cleaner to iterate through allowedRuntimes and allocate
the new objects by class name via reflection instead of hard-coding all of them
I've always tried to reserve reflection for cases where I don't know a class and its functionality
at compile time. In this case we do. Again, if there is a strong opinion that the trade off
is worth it, I can pursue a patch that leverages reflection.

> Admins should be able to explicitly enable specific LinuxContainerRuntime in the NodeManager
> --------------------------------------------------------------------------------------------
>                 Key: YARN-6930
>                 URL: https://issues.apache.org/jira/browse/YARN-6930
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Shane Kumpf
>         Attachments: YARN-6930.001.patch, YARN-6930.002.patch, YARN-6930.003.patch
> Today, in the java land, all LinuxContainerRuntimes are always enabled when using LinuxContainerExecutor
and the user can simply invoke anything that he/she wants - default, docker, java-sandbox.
> We should have a way for admins to explicitly enable only specific runtimes that he/she
decides for the cluster. And by default, we should have everything other than the default
one disabled.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message