hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuan Gong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6877) Create an abstract log reader for extendability
Date Tue, 29 Aug 2017 23:57:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146367#comment-16146367
] 

Xuan Gong commented on YARN-6877:
---------------------------------

bq. In LogCLIHelpers.java, I saw we are mixing using err.println() and System.err.println().
Both way should works fine but better to keep consistent here.

This is because some of the function use (PrintStream err) as parameter input, so err.println()
will be used. For the functions which do not have (PrintStream err) as parameter, we use System.err.println()

Uploaded a new patch for other comments.

> Create an abstract log reader for extendability
> -----------------------------------------------
>
>                 Key: YARN-6877
>                 URL: https://issues.apache.org/jira/browse/YARN-6877
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-6877-branch-2.001.patch, YARN-6877-trunk.001.patch, YARN-6877-trunk.002.patch,
YARN-6877-trunk.003.patch, YARN-6877-trunk.004.patch, YARN-6877-trunk.005.patch, YARN-6877-trunk.006.patch
>
>
> Currently, TFile log reader is used to read aggregated log in YARN. We need to add an
abstract layer, and pick up the correct log reader based on the configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message