hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6876) Create an abstract log writer for extendability
Date Wed, 23 Aug 2017 20:36:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139039#comment-16139039

Junping Du commented on YARN-6876:

Thanks [~xgong] for updating the patch. The latest patch looks much better!
A few minor comments:
In yarn-default.xml, "yarn.log-aggregation.file-controllers" better to change to file-formats
for better understanding. But "yarn.log-aggregation.file-controller.TFile.class" and other
implementation class name (with controller) should be fine.

LogAggregationFileController.java is supposed to be a public interface so third-party can
implement its own log format. We should add public, unstable annotation to the class. If we
concern it is too early to get public, then we should have a separated jira to track this
effort when it is becoming more stable.

Other looks fine to me. 

> Create an abstract log writer for extendability
> -----------------------------------------------
>                 Key: YARN-6876
>                 URL: https://issues.apache.org/jira/browse/YARN-6876
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-6876-branch-2.001.patch, YARN-6876-trunk.001.patch, YARN-6876-trunk.002.patch,
YARN-6876-trunk.003.patch, YARN-6876-trunk.004.patch, YARN-6876-trunk.005.patch
> Currently, TFile log writer is used to aggregate log in YARN. We need to add an abstract
layer, and pick up the correct log writer based on the configuration.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message