hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bibin A Chundatt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6855) CLI Proto Modifications to support Node Attributes
Date Wed, 16 Aug 2017 09:42:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128560#comment-16128560
] 

Bibin A Chundatt commented on YARN-6855:
----------------------------------------

One minor nit:

{code}
79	  @Override
80	  public void setNodesToAttributes(List<NodeToAttributes> nodesToAttributes) {
81	    if (nodeAttributesMapping == null) {
82	      nodeAttributesMapping = new ArrayList<>();
83	    }
84	    nodeAttributesMapping.clear();
85	    nodeAttributesMapping.addAll(nodesToAttributes);
86	  }
{code}

if nodesToAttributes==null no need to add to nodeAttributesMapping



> CLI Proto Modifications to support Node Attributes
> --------------------------------------------------
>
>                 Key: YARN-6855
>                 URL: https://issues.apache.org/jira/browse/YARN-6855
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, capacityscheduler, client
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-6855-YARN-3409.001.patch, YARN-6855-YARN-3409.002.patch, YARN-6855-YARN-3409.003.patch,
YARN-6855-YARN-3409.004.patch, YARN-6855-YARN-3409.005.patch
>
>
> This jira focuses only on the proto modifications required for the CLI



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message