hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6033) Add support for sections in container-executor configuration file
Date Sat, 05 Aug 2017 01:17:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115181#comment-16115181
] 

Miklos Szegedi commented on YARN-6033:
--------------------------------------

Sorry, I think I found one more in the latest patch.
{code}
58	// free an entry set of values
59	void free_values(char** values) {
60	  if (*values != NULL) {
61	    free(*values);
62	  }
63	  if (values != NULL) {
64	    free(values);
65	  }
66	}
{code}
If I understand correctly this does not free all values, just the first value. This is expected,
if the items come from strtok, so this would definitely deserve a comment.
Moreover, if strtok finds a delimiter on the first character, the first value is inside the
string, so free will crash and leak the memory.

> Add support for sections in container-executor configuration file
> -----------------------------------------------------------------
>
>                 Key: YARN-6033
>                 URL: https://issues.apache.org/jira/browse/YARN-6033
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-6033.003.patch, YARN-6033.004.patch, YARN-6033.005.patch, YARN-6033.006.patch,
YARN-6033.007.patch, YARN-6033.008.patch, YARN-6033.009.patch, YARN-6033-YARN-5673.001.patch,
YARN-6033-YARN-5673.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message