hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiandan Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5951) Changes to allow CapacityScheduler to use configuration store
Date Wed, 02 Aug 2017 08:09:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110501#comment-16110501
] 

Jiandan Yang  commented on YARN-5951:
-------------------------------------

[~jhung] [~leftnoteasy] I found this patch has two problems:
1. MutableCSConfigurationProvider#recoverConf iterator PendingMutations´╝îcalling removeFirst
in confirmMutation will lead to ConcurrentModificationException
{code:java}
List<LogMutation> uncommittedLogs = confStore.getPendingMutations();
    Configuration oldConf = new Configuration(schedConf);
    for (LogMutation mutation : uncommittedLogs) {
      ......
      confStore.confirmMutation(mutation.getId(), true);
      ......
    }
{code}

2. LeveldbConfigurationStore#initialize should update txnId after  pendingMutations.add

{code:java}
      while (itr.hasNext()) {
        Map.Entry<byte[], byte[]> entry = itr.next();
        if (!new String(entry.getKey(), StandardCharsets.UTF_8)
            .startsWith(LOG_PREFIX)) {
          break;
        }
        pendingMutations.add(deserLogMutation(entry.getValue()));
        txnId = deserLogMutation(entry.getValue()).getId();                    // update txnId

      }
{code}




> Changes to allow CapacityScheduler to use configuration store
> -------------------------------------------------------------
>
>                 Key: YARN-5951
>                 URL: https://issues.apache.org/jira/browse/YARN-5951
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>             Fix For: YARN-5734
>
>         Attachments: YARN-5951-YARN-5734.001.patch, YARN-5951-YARN-5734.002.patch, YARN-5951-YARN-5734.003.patch,
YARN-5951-YARN-5734.004.patch
>
>
> EDIT: changing this ticket. Found that the CapacityStoreConfigurationProvider is not
necessary, since we can just grab a Configuration object from StoreConfigurationProvider with
type "SCHEDULER" and create a CapacitySchedulerConfiguration from it.
> This ticket will track changes needed for integrating other components to be used by
the capacity scheduler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message