Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2E427200CC8 for ; Fri, 14 Jul 2017 18:00:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2CA8C16DA6E; Fri, 14 Jul 2017 16:00:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7366716DA51 for ; Fri, 14 Jul 2017 18:00:07 +0200 (CEST) Received: (qmail 63207 invoked by uid 500); 14 Jul 2017 16:00:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 63196 invoked by uid 99); 14 Jul 2017 16:00:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2017 16:00:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0BC5BC008F for ; Fri, 14 Jul 2017 16:00:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MntiEfA4mgWC for ; Fri, 14 Jul 2017 16:00:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9B03B5FB62 for ; Fri, 14 Jul 2017 16:00:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A39CE0BB3 for ; Fri, 14 Jul 2017 16:00:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6AC3124745 for ; Fri, 14 Jul 2017 16:00:01 +0000 (UTC) Date: Fri, 14 Jul 2017 16:00:01 +0000 (UTC) From: "Billie Rinaldi (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6804) Allow custom hostname for docker containers in native services MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 14 Jul 2017 16:00:08 -0000 [ https://issues.apache.org/jira/browse/YARN-6804?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16087= 517#comment-16087517 ]=20 Billie Rinaldi commented on YARN-6804: -------------------------------------- bq. I think the check for if =E2=80=9CLOG.isInfoEnabled=E2=80=9D is not req= uired Most of the LOG.info checks in DockerLinuxContainerRuntime have LOG.isInfoE= nabled() before them (not sure why), so I was trying to match those. Do you= think we should remove them all? bq. the network parameter is not used, and the added NETWORK_TYPE_BRIDGE se= ems also not used You're right, I had a version of the patch where I only set the hostname wh= en the network type was bridge, but then I read that docker hostname can be= set even if network is host, so I removed it. bq. probably we can create a common util method in RegistryPathUtils Good point. Actually there's already a method for that, we can just make en= codeYarnID perform the ctr replacement as well. > Allow custom hostname for docker containers in native services > -------------------------------------------------------------- > > Key: YARN-6804 > URL: https://issues.apache.org/jira/browse/YARN-6804 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-native-services > Reporter: Billie Rinaldi > Assignee: Billie Rinaldi > Fix For: yarn-native-services > > Attachments: YARN-6804-yarn-native-services.001.patch, YARN-6804-= yarn-native-services.002.patch > > > Instead of the default random docker container hostname, we could set a m= ore user-friendly hostname for the container. The default could be a hostna= me based on the container ID, with an option for the AM to provide a differ= ent hostname. In the case of the native services AM, we could provide the h= ostname that would be created by the registry DNS server. Regardless of whe= ther or not registry DNS is enabled, this would be a more useful hostname f= or the docker container. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org