Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 6 Jul 2017 04:14:01 +0000 (UTC)
From: "Jian He (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12759285.1417641333000.180571.1499314441131@Atlassian.JIRA>
In-Reply-To: <JIRA.12759285.1417641333000@Atlassian.JIRA>
References: <JIRA.12759285.1417641333000@Atlassian.JIRA> <JIRA.12759285.1417641333537@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-2919) Potential race between renew and
 cancel in DelegationTokenRenwer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 06 Jul 2017 04:14:06 -0000


    [ https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075901#comment-16075901 ] 

Jian He commented on YARN-2919:
-------------------------------

got a question, [~Naganarasimha], could you elaborate what the race condition is based on code? The jira description is a bit vague.
The patch uses a local variable in the token itself to indicate cancelling, I'm unsure if this is a good way. Caller can just make a copy of the token and do all sorts of operation and this flag becomes moot.
Also, there are some behavior changes, the return value of renew method was supposed to be the expiration time, now '-1' is returned as an error code, which old program does not understand - old program was expecting an exception if renew fails. And it's possible for old program to wrongly interprets the '-1' as the expiration time. 


> Potential race between renew and cancel in DelegationTokenRenwer 
> -----------------------------------------------------------------
>
>                 Key: YARN-2919
>                 URL: https://issues.apache.org/jira/browse/YARN-2919
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2919.002.patch, YARN-2919.003.patch, YARN-2919.004.patch, YARN-2919.005.patch, YARN-2919.20141209-1.patch
>
>
> YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a race because of which a renewal in flight isn't interrupted by a cancel. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org