From yarn-issues-return-118316-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Tue Jul 25 18:25:07 2017 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9380E198FD for ; Tue, 25 Jul 2017 18:25:07 +0000 (UTC) Received: (qmail 51755 invoked by uid 500); 25 Jul 2017 18:25:06 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 51706 invoked by uid 500); 25 Jul 2017 18:25:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 51584 invoked by uid 99); 25 Jul 2017 18:25:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jul 2017 18:25:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8C33FC030E for ; Tue, 25 Jul 2017 18:25:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KomCYpITw_ns for ; Tue, 25 Jul 2017 18:25:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AF41160EF9 for ; Tue, 25 Jul 2017 18:25:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 421C7E0E6A for ; Tue, 25 Jul 2017 18:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 029EB23FB8 for ; Tue, 25 Jul 2017 18:25:01 +0000 (UTC) Date: Tue, 25 Jul 2017 18:25:01 +0000 (UTC) From: "Daniel Templeton (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (YARN-6869) Resources.lessThan() et al should not use ResourceCalculator.compare() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Daniel Templeton created YARN-6869: -------------------------------------- Summary: Resources.lessThan() et al should not use ResourceCalculator.compare() Key: YARN-6869 URL: https://issues.apache.org/jira/browse/YARN-6869 Project: Hadoop YARN Issue Type: Improvement Components: resourcemanager Affects Versions: 3.0.0-alpha4 Reporter: Daniel Templeton If you look at what the callers of {{lessThan()}}, {{lessThanOrEqual()}}, {{greaterThan()}}, and {{greaterThanOrEqual()}} expect the calls to do, there's no reason why the comparison should be done in context of the total resources. Skipping the division and doing a direct comparison should improve performance. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org