From yarn-issues-return-117093-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Mon Jul 10 18:49:32 2017 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 398751AEA8 for ; Mon, 10 Jul 2017 18:49:32 +0000 (UTC) Received: (qmail 41184 invoked by uid 500); 10 Jul 2017 18:49:32 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 41140 invoked by uid 500); 10 Jul 2017 18:49:31 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 41128 invoked by uid 99); 10 Jul 2017 18:49:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2017 18:49:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5386B193F0C for ; Mon, 10 Jul 2017 18:49:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 17Nn5MGMPuUl for ; Mon, 10 Jul 2017 18:49:30 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 16AD762B9D for ; Mon, 10 Jul 2017 18:31:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 454E9E0984 for ; Mon, 10 Jul 2017 18:31:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 80C3A246B1 for ; Mon, 10 Jul 2017 18:31:00 +0000 (UTC) Date: Mon, 10 Jul 2017 18:31:00 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-6706) Refactor ContainerScheduler to make oversubscription change easier MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080813#comment-16080813 ] Karthik Kambatla commented on YARN-6706: ---------------------------------------- I feel we should get this into trunk directly instead of YARN-1011 branch. The current patch looks okay, Can we add a few more things: # Make ResourceUtilizationTracker pluggable. That way, we could use a different tracker when oversubscription is enabled. # ContainerScheduler ## Why do we need maxOppQueueLength given queuingLimit? ## Is there value in splitting runningContainers into runningGuaranteed and runningOpportunistic? ## getOpportunisticContainersStatus method implementation feels awkward. How about capturing the state in the field here, and have metrics etc. pull from here? ## startContainersFromQueue: Local variable resourcesAvailable is unnecessary # OpportunisticContainersStatus ## Let us clearly differentiate between allocated, used and utilized. Maybe, we should rename current *Used* methods to *Allocated*? ## I prefer either full name Opportunistic (in method) or Opp (shortest name that makes sense). Opport is neither short nor fully descriptive. ## Have we considered folding ContainerQueuingLimit class into this? /cc [~asuresh] and [~kkaranasos] > Refactor ContainerScheduler to make oversubscription change easier > ------------------------------------------------------------------ > > Key: YARN-6706 > URL: https://issues.apache.org/jira/browse/YARN-6706 > Project: Hadoop YARN > Issue Type: Sub-task > Affects Versions: 3.0.0-alpha3 > Reporter: Haibo Chen > Assignee: Haibo Chen > Attachments: YARN-6706-YARN-1011.00.patch, YARN-6706-YARN-1011.01.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org