[ https://issues.apache.org/jira/browse/YARN-6903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106993#comment-16106993
]
Hadoop QA commented on YARN-6903:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color}
| {color:green} The patch appears to include 58 new or modified test files. {color} |
|| || || || {color:brown} yarn-native-services Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 6s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 55s{color}
| {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 46s{color} |
{color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 31s{color}
| {color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 6m 10s{color} |
{color:green} yarn-native-services passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 27s{color} |
{color:green} yarn-native-services passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 44s{color} |
{color:green} yarn-native-services passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 39s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 19s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 6m 19s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 6m 19s{color} | {color:red}
hadoop-yarn-project_hadoop-yarn generated 3 new + 133 unchanged - 5 fixed = 136 total (was
138) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 26s{color}
| {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 517 new + 1360 unchanged
- 398 fixed = 1877 total (was 1758) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 6m 54s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 22s{color}
| {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 11s{color}
| {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red}
The patch has 26 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red}
The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue}
Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 6s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
generated 30 new + 0 unchanged - 0 fixed = 30 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 44s{color} | {color:red}
hadoop-yarn in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 20s{color} | {color:red}
hadoop-yarn-slider-core in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 6m 0s{color} | {color:red}
hadoop-yarn in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 37s{color} | {color:red}
hadoop-yarn-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 9s{color} | {color:green}
hadoop-yarn-registry in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 1s{color} | {color:red}
hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 37m 6s{color} | {color:red}
hadoop-yarn-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 54s{color} | {color:red}
hadoop-yarn-slider-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 33s{color} | {color:green}
hadoop-yarn-services-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 52s{color} | {color:red}
The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}199m 13s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
|
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$ComponentCountProto.PARSER isn't final
but should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 833] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$ComponentCountProto defines non-transient
non-serializable instance field unknownFields In ClientAMProtocol.java:instance field unknownFields
In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$ComponentCountProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 1101] |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$FlexComponentsRequestProto.PARSER isn't
final but should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 125] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$FlexComponentsRequestProto defines
non-transient non-serializable instance field unknownFields In ClientAMProtocol.java:instance
field unknownFields In ClientAMProtocol.java |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$FlexComponentsResponseProto.PARSER isn't
final but should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 1396] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$FlexComponentsResponseProto defines
non-transient non-serializable instance field unknownFields In ClientAMProtocol.java:instance
field unknownFields In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$FlexComponentsResponseProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 1570] |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusRequestProto.PARSER isn't final
but should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 1734] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusRequestProto defines non-transient
non-serializable instance field unknownFields In ClientAMProtocol.java:instance field unknownFields
In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusRequestProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 1908] |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusResponseProto.PARSER isn't final
but should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 2093] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusResponseProto defines non-transient
non-serializable instance field unknownFields In ClientAMProtocol.java:instance field unknownFields
In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$GetStatusResponseProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 2328] |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$StopRequestProto.PARSER isn't final but
should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 2581] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$StopRequestProto defines non-transient
non-serializable instance field unknownFields In ClientAMProtocol.java:instance field unknownFields
In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$StopRequestProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 2755] |
| | org.apache.hadoop.yarn.proto.ClientAMProtocol$StopResponseProto.PARSER isn't final but
should be At ClientAMProtocol.java:be At ClientAMProtocol.java:[line 2919] |
| | Class org.apache.hadoop.yarn.proto.ClientAMProtocol$StopResponseProto defines non-transient
non-serializable instance field unknownFields In ClientAMProtocol.java:instance field unknownFields
In ClientAMProtocol.java |
| | Useless control flow in org.apache.hadoop.yarn.proto.ClientAMProtocol$StopResponseProto$Builder.maybeForceBuilderInitialization()
At ClientAMProtocol.java: At ClientAMProtocol.java:[line 3093] |
| | Switch statement found in org.apache.hadoop.yarn.service.client.ServiceCLI.exec(ClientArgs)
where default case is missing At ServiceCLI.java:where default case is missing At ServiceCLI.java:[lines
40-71] |
| | Boxing/unboxing to parse a primitive org.apache.hadoop.yarn.service.client.ServiceClient.parseNumberOfContainers(Component,
String) At ServiceClient.java:org.apache.hadoop.yarn.service.client.ServiceClient.parseNumberOfContainers(Component,
String) At ServiceClient.java:[line 237] |
| | org.apache.hadoop.yarn.service.compinstance.ComponentInstance defines compareTo(ComponentInstance)
and uses Object.equals() At ComponentInstance.java:Object.equals() At ComponentInstance.java:[lines
465-471] |
| | Boxing/unboxing to parse a primitive org.apache.slider.api.resource.Resource.getMemoryMB()
At Resource.java:org.apache.slider.api.resource.Resource.getMemoryMB() At Resource.java:[line
107] |
| | Non-virtual method call in org.apache.slider.providers.AbstractProviderService.buildContainerLaunchContext(ContainerLauncher,
Application, Container, ProviderRole, SliderFileSystem, RoleInstance) passes null for non-null
parameter of org.apache.hadoop.yarn.service.provider.ProviderUtils.initCompTokensForSubstitute(ComponentInstance)
At AbstractProviderService.java:Application, Container, ProviderRole, SliderFileSystem, RoleInstance)
passes null for non-null parameter of org.apache.hadoop.yarn.service.provider.ProviderUtils.initCompTokensForSubstitute(ComponentInstance)
At AbstractProviderService.java:[line 81] |
| | Dead store to providerService in org.apache.slider.server.appmaster.SliderAppMaster.onContainerStatusReceived(ContainerId,
ContainerStatus) At SliderAppMaster.java:org.apache.slider.server.appmaster.SliderAppMaster.onContainerStatusReceived(ContainerId,
ContainerStatus) At SliderAppMaster.java:[line 1966] |
| | Dead store to cid in org.apache.slider.server.appmaster.SliderAppMaster.unregisterComponent(RoleInstance)
At SliderAppMaster.java:org.apache.slider.server.appmaster.SliderAppMaster.unregisterComponent(RoleInstance)
At SliderAppMaster.java:[line 1226] |
| | Null passed for non-null parameter of org.apache.hadoop.yarn.service.timelineservice.ServiceTimelinePublisher.componentInstanceStarted(Container,
ComponentInstance) in org.apache.slider.server.appmaster.SliderAppMaster.registerComponent(ContainerId,
RoleInstance) At SliderAppMaster.java:of org.apache.hadoop.yarn.service.timelineservice.ServiceTimelinePublisher.componentInstanceStarted(Container,
ComponentInstance) in org.apache.slider.server.appmaster.SliderAppMaster.registerComponent(ContainerId,
RoleInstance) At SliderAppMaster.java:[line 1194] |
| | Boxing/unboxing to parse a primitive org.apache.slider.util.ServiceApiUtil.validateCompResourceSize(Resource,
Application) At ServiceApiUtil.java:org.apache.slider.util.ServiceApiUtil.validateCompResourceSize(Resource,
Application) At ServiceApiUtil.java:[line 354] |
| | org.apache.slider.util.ServiceApiUtil.jsonSerDeser isn't final and can't be protected
from malicious code At ServiceApiUtil.java:be protected from malicious code At ServiceApiUtil.java:[line
56] |
| Failed junit tests | hadoop.yarn.service.conf.TestLoadExampleAppJson |
| | slider.server.appmaster.model.appstate.TestMockAppStateDynamicRoles |
| | hadoop.yarn.service.client.TestServiceCLI |
| | hadoop.yarn.client.api.impl.TestNMClient |
| | hadoop.yarn.server.resourcemanager.TestRMRestart |
| | hadoop.yarn.util.TestBoundedAppender |
| | hadoop.yarn.util.TestBoundedAppender |
| | hadoop.yarn.server.resourcemanager.TestRMRestart |
| | hadoop.yarn.client.api.impl.TestNMClient |
| | hadoop.yarn.service.conf.TestLoadExampleAppJson |
| | slider.server.appmaster.model.appstate.TestMockAppStateDynamicRoles |
| | hadoop.yarn.service.client.TestServiceCLI |
| Timed out junit tests | org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
|
| | org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA |
| | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient |
| | org.apache.hadoop.yarn.service.TestYarnNativeServices |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | YARN-6903 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879563/YARN-6903.yarn-native-services.01.patch
|
| Optional Tests | asflicense shellcheck shelldocs compile javac javadoc mvninstall
mvnsite unit findbugs checkstyle xml cc |
| uname | Linux 39c4729f4a20 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | yarn-native-services / f1a358e |
| Default Java | 1.8.0_131 |
| shellcheck | v0.4.6 |
| findbugs | v3.1.0-RC1 |
| javac | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/diff-compile-javac-hadoop-yarn-project_hadoop-yarn.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/whitespace-eol.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.html
|
| javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
|
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
|
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
|
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
|
| unit | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-slider_hadoop-yarn-slider-core.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/16614/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-YARN-Build/16614/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-slider/hadoop-yarn-slider-core
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api U: hadoop-yarn-project/hadoop-yarn
|
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/16614/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Yarn-native-service framework core rewrite
> ------------------------------------------
>
> Key: YARN-6903
> URL: https://issues.apache.org/jira/browse/YARN-6903
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-6903.yarn-native-services.01.patch
>
>
> There are some new features like rich placement scheduling, container auto restart, container
upgrade in YARN core that can be taken advantage by the native-service framework. Besides,
there are quite a lot legacy code which are no longer required.
> So we decide to rewrite the core part to have a leaner codebase and make use of various
advanced features in YARN.
> And the new code design will be in align with what we have designed for the service API
YARN-4793
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org
|