hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6892) Improve API implementation in Resources and DominantResourceCalculator in align to ResourceInformation
Date Mon, 31 Jul 2017 22:50:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108111#comment-16108111
] 

Wangda Tan commented on YARN-6892:
----------------------------------

Thanks [~sunilg], 

Took a quick scan of changes in DRC, it looks good, I will do another thorough review once
YARN-6788 get committed.

Two suggestions:
1) getResourceInformation/setResourceValue should be private.
2) Should use "long" instead of "Long" for less boxing op?

> Improve API implementation in Resources and DominantResourceCalculator in align to ResourceInformation
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6892
>                 URL: https://issues.apache.org/jira/browse/YARN-6892
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: YARN-6892-YARN-3926.001.patch
>
>
> In YARN-3926, apis in Resources and DRC spents significant cpu cycles in most of its
api. For better performance, its better to improve the apis as resource types order is defined
in system level (ResourceUtils class ensures this post YARN-6788)
> This work is preceding to YARN-6788



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message