hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenxin He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6873) Moving logging APIs over to slf4j in hadoop-yarn-server-applicationhistoryservice
Date Mon, 31 Jul 2017 04:19:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106792#comment-16106792
] 

Wenxin He commented on YARN-6873:
---------------------------------

Mostly looks good to me, except some minor nits: 

# checkstyle warnings: All Indentation and LineLength warnings can be fixed.
# checkstyle warnings: StaticVariableName warning can be fixed by making the LOG *final*.
# indentation level 6 would be better:
{noformat}
+  private static final Logger LOG =
+          LoggerFactory.getLogger(ApplicationHistoryClientService.class);
{noformat}
{noformat}
+  private static final Logger LOG =
+          LoggerFactory.getLogger(ApplicationHistoryManagerImpl.class);
{noformat}

> Moving logging APIs over to slf4j in hadoop-yarn-server-applicationhistoryservice
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-6873
>                 URL: https://issues.apache.org/jira/browse/YARN-6873
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Yeliang Cang
>            Assignee: Yeliang Cang
>         Attachments: YARN-6873.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message