hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vrushali C (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6861) Reader API for sub application entities
Date Fri, 28 Jul 2017 23:59:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105876#comment-16105876
] 

Vrushali C edited comment on YARN-6861 at 7/28/17 11:58 PM:
------------------------------------------------------------

Thanks [~rohithsharma] for the patch!

I had some basic questions and a few javadoc related nits:

- we need to add the new rest api in the documentation TimelineServiceV2.md file

In SubApplicationEntityReader.java
- update the class javadoc comment for L64 Change Entitytable => Subapp table
- update L88 Entitytable => Subapp table
- Am trying figure out if there is any difference between SubApplicationEntityReader  # readKeyValuePairs
and GenericEntityReader# readKeyValuePairs? If not, it can be reused? I think the other readers
are using the readKeyValuePairs from GenericEntityReader.
- also there is a stub method getResult at L 613. Trying to understand why is it needed. 

In TimelineReaderWebServices
- Could we add a comment above the function saying this REST endpoint returns sub application
entities? I think it may not be clear to other developers that this isn’t the regular entities
but is querying for sub app entities.

- If I am understanding correctly, if the doAsUser is set in the context, this fetches the
sub application entities, else it will return the Generic entity reader in TimelineEntityReaderFactory?

So is the understanding correct that this API will NOT invoke the sub application table explicitly
if the UGI does not have the doAsUser set?  If so, it’s sort of happening behind the scenes.


I am not sure if this is a very clean way. I am wondering how will this work from a browser
if I as a user want to fetch sub app entities for  another user, say Varun?  

Perhaps just accept the sub app user id as a Query param just like we accept userId? Also
perhaps we can call the end point something else so that it’s clear that we have sub application
entities not regular entities? 






was (Author: vrushalic):
Thanks [~rohithsharma] for the patch!

I had some basic questions and a few javadoc related nits:

- we need to add the new rest api in the documentation TimelineServiceV2.md file

In SubApplicationEntityReader.java
- update the class javadoc comment for L64 Change Entitytable => Subapp table
- update L88 Entitytable => Subapp table
- Am trying figure out if there is any difference between SubApplicationEntityReader  # readKeyValuePairs
and GenericEntityReader# readKeyValuePairs? If not, it can be reused? I think the other readers
are using the readKeyValuePairs from GenericEntityReader.
- also there is a stub method getResult at L 613. Trying to understand why is it needed. 

In TimelineReaderWebServices
- Could we add a comment above the function saying this REST endpoint returns sub application
entities? I think it may not be clear to other developers that this isn’t the regular entities
but is querying for sub app entities.

- If I am understanding correctly, if the doAsUser is set in the context, this fetches the
sub application entities, else it will return the Generic entity reader in TimelineEntityReaderFactory?

So is the understanding correct that this API will NOT invoke the sub application table explicitly
if the UGI does not have the doAsUser set?  If so, it’s sort of happening behind the scenes.


I am not sure if this is a very clean way. I am wondering wow will this work from a browser
if I as a user want to fetch sub app entities for say, user Varun?  

Perhaps just accept the sub app user id as a Query param just like we accept userId? Also
perhaps we can call the end point something else so that it’s clear that we have sub application
entities not regular entities? 





> Reader API for sub application entities
> ---------------------------------------
>
>                 Key: YARN-6861
>                 URL: https://issues.apache.org/jira/browse/YARN-6861
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-6861-YARN-5355.001.patch
>
>
> YARN-6733 and YARN-6734 writes data into sub application table. There should be a way
to read those entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message