hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6855) CLI Proto Modifications to support Node Attributes
Date Tue, 25 Jul 2017 20:52:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100760#comment-16100760
] 

Wangda Tan commented on YARN-6855:
----------------------------------

Thanks [~naganarasimha_gr@apache.org] for working on the patch, quickly scanned the patch,
few comments:
1) Suggest to make all {{@Public}} apis to {{@Public/Unstable}} since this is new feature
which is expected to be changed, we can upgrade its compatibility tag after a few releases.

2) NodeIdToAttributes: suggest to update it to HostToAttribute as we discussed in YARN-3409.
3) Only one method is added in resourcemanager_administration_protocol.proto, is it enough?

> CLI Proto Modifications to support Node Attributes
> --------------------------------------------------
>
>                 Key: YARN-6855
>                 URL: https://issues.apache.org/jira/browse/YARN-6855
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, capacityscheduler, client
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-6855-YARN-3409.001.patch, YARN-6855-YARN-3409.002.patch, YARN-6855-YARN-3409.003.patch
>
>
> This jira focuses only on the proto modifications required for the CLI



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message