hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6804) Allow custom hostname for docker containers in native services
Date Thu, 13 Jul 2017 19:32:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086276#comment-16086276
] 

Jian He commented on YARN-6804:
-------------------------------

lgtm, two minor comments:
- I think the check for if  “LOG.isInfoEnabled” is not required 
{code}
if (LOG.isInfoEnabled()) {
  LOG.info("setting hostname in container to: " + name);
}
{code}
- the network parameter is not used, and the added NETWORK_TYPE_BRIDGE seems also not used
{code}
private void setHostname(DockerRunCommand runCommand, String
    containerIdStr, String
network, String name)
{code}

> Allow custom hostname for docker containers in native services
> --------------------------------------------------------------
>
>                 Key: YARN-6804
>                 URL: https://issues.apache.org/jira/browse/YARN-6804
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-native-services
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: yarn-native-services
>
>         Attachments: YARN-6804-yarn-native-services.001.patch, YARN-6804-yarn-native-services.002.patch
>
>
> Instead of the default random docker container hostname, we could set a more user-friendly
hostname for the container. The default could be a hostname based on the container ID, with
an option for the AM to provide a different hostname. In the case of the native services AM,
we could provide the hostname that would be created by the registry DNS server. Regardless
of whether or not registry DNS is enabled, this would be a more useful hostname for the docker
container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message