hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6777) Support for ApplicationMasterService processing chain of interceptors
Date Tue, 18 Jul 2017 22:45:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092285#comment-16092285
] 

Subru Krishnan commented on YARN-6777:
--------------------------------------

Thanks [~asuresh] for updating the patch, this LGTM. I have one question - is it OK to propagate
the exception in *getProcessorList* out of {{ApplicationMasterService}}?

I have a minor nit on code comments:
* Call out in {{DefaultAMSProcessor}} that it *must* be the last interceptor in the chain.
* In {{ApplicationMasterService}}, where it ensures the above.
* In {{OpportunisticContainerAllocatorAMService}}, why next interceptor will never be null
due to above.

> Support for ApplicationMasterService processing chain of interceptors
> ---------------------------------------------------------------------
>
>                 Key: YARN-6777
>                 URL: https://issues.apache.org/jira/browse/YARN-6777
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-6777.001.patch, YARN-6777.002.patch, YARN-6777.003.patch, YARN-6777.004.patch,
YARN-6777.005.patch
>
>
> This JIRA extends the Processor introduced in YARN-6776 with a configurable processing
chain of interceptors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message