[ https://issues.apache.org/jira/browse/YARN-6769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084558#comment-16084558
]
Yufei Gu commented on YARN-6769:
--------------------------------
Thanks for the new patch. Some nits:
# Can we change Java doc to "Schedulables without resource demand get lower priority than
ones whose with."? Avoid to use {{Resources.none}} since descriptive words are better than
code in Java doc.
# Is it better to use {{Resources.greaterThan(RESOURCE_CALCULATOR, null, demand2, Resources.none())}}
instead of {{!demand2.equals(Resources.none())}}? It is possible that resource could be negative.
The former is less error-prone.
> Put the no demand queue after the most in FairSharePolicy#compare
> -----------------------------------------------------------------
>
> Key: YARN-6769
> URL: https://issues.apache.org/jira/browse/YARN-6769
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.7.2
> Reporter: daemon
> Assignee: daemon
> Priority: Minor
> Fix For: 2.9.0
>
> Attachments: YARN-6769.001.patch, YARN-6769.002.patch, YARN-6769.003.patch
>
>
> When use fairsheduler as RM scheduler, before assign container we will sort all queues
or applications.
> We will use FairSharePolicy#compare as the comparator， but the comparator is not so
perfect.
> It have a problem as blow:
> 1. when a queue use resource over minShare(minResources), it will put behind the queue
whose demand is zeor.
> so it will greater opportunity to get the resource although it do not want. It will waste
schedule time when assign container
> to queue or application.
> I have fix it, and I will upload the patch to the jira.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org
|