hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6768) Improve performance of yarn api record toString and fromString
Date Fri, 21 Jul 2017 20:43:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096821#comment-16096821
] 

Jason Lowe commented on YARN-6768:
----------------------------------

Thanks for updating the patch!  I think we're almost there.

It looks like Nathan's comment was missed:
{quote}
Probably don't need to calculate full numDigits. once you have minimumDigits, you're done.
{quote}

We can cheaply add that check by adding a {{--minimumDigits > 0}} condition to the loop.
 Then we no longer need numDigits at all and can simply loop minimumDigits times to add the
prefix zeroes.

It would also be good to move the relevant tests out of TestConverterUtils and into something
like TestConversions unit test in hadoop-yarn-api.  Many of those tests are really testing
classes in hadoop-yarn-api and not even referencing ConverterUtils.  We can defer the test
cleanup to a followup JIRA if desired.


> Improve performance of yarn api record toString and fromString
> --------------------------------------------------------------
>
>                 Key: YARN-6768
>                 URL: https://issues.apache.org/jira/browse/YARN-6768
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: YARN-6768.1.patch, YARN-6768.2.patch, YARN-6768.3.patch, YARN-6768.4.patch,
YARN-6768.5.patch, YARN-6768.6.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message