hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yeliang Cang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6765) CGroupsHandlerImpl.initializeControllerPaths() should include cause when chaining exceptions
Date Thu, 06 Jul 2017 12:43:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076432#comment-16076432
] 

Yeliang Cang commented on YARN-6765:
------------------------------------

patch002, fix one checkstyle and three findbug warnings.

Two findbugs remain unchanged:
Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
The "/sys/fs/cgroup" path is OS cgroup path, and cannot be modified.

Useless object stored in variable removedNullContainers of method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)
I do not think it is suitable to remove variable removedNullContainers. Maybe it can be used
in the future work.

> CGroupsHandlerImpl.initializeControllerPaths() should include cause when chaining exceptions
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-6765
>                 URL: https://issues.apache.org/jira/browse/YARN-6765
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.8.1, 3.0.0-alpha3
>            Reporter: Daniel Templeton
>            Assignee: Yeliang Cang
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-6765-001.patch, YARN-6765-002.patch
>
>
> This: {code}      throw new ResourceHandlerException(
>           "Failed to initialize controller paths!");{code} should be this: {code}   
  throw new ResourceHandlerException(
>           "Failed to initialize controller paths!", e);{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message