hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6757) Refactor the usage of yarn.nodemanager.linux-container-executor.cgroups.mount-path
Date Mon, 31 Jul 2017 19:00:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107785#comment-16107785
] 

Daniel Templeton commented on YARN-6757:
----------------------------------------

Thanks for the update, [~miklos.szegedi@cloudera.com].  A few more comments, mostly language/grammar:

* The {{ResourceHandlerModule}} methods ({{getTrafficControlBandwidthHandler}}, et al) where
you fixed the indentation should now have the third line indented two more spaces.
* In {{yarn-defaults.xml}}:
** "so use this setting only, if the discovery does not work" shouldn't have a comma.
** Yarn should be YARN.
** I really struggle with this whole text.  What about something like: "This property sets
the path from which YARN will read the CGroups configuration. YARN has built-in functionality
to discover the system CGroup mount paths, so use this property only if YARN's automatic mount
path discovery does not work. The path specified by this property must exist before the NodeManager
is launched. If yarn.nodemanager.linux-container-executor.cgroups.mount is set to true, YARN
will first try to mount the CGroups at the specified path before reading them. Please refer
to NodeManagerCgroups.html in the documentation for further details. This property only applies
when the LCE resources handler is set to CgroupsLCEResourcesHandler."
* In {{NodeManagerCgroups.md}}:
** In the definition of yarn.nodemanager.linux-container-executor.cgroups.mount-path, I think
you're better off just saying, "Optional. See _CGroups mount options_ below for details."
** Yarn should be YARN.
** "leave other settings default" => "leave other settings set to the defaults"
** "Mount CGroups by Yarn" => "CGroups mounted by YARN"
** "CGroups mounted or linked already but not in `/proc/mounts`" => "CGroups already mounted
or linked but not in `/proc/mounts`"

> Refactor the usage of yarn.nodemanager.linux-container-executor.cgroups.mount-path
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-6757
>                 URL: https://issues.apache.org/jira/browse/YARN-6757
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>         Attachments: YARN-6757.000.patch, YARN-6757.001.patch, YARN-6757.002.patch, YARN-6757.003.patch
>
>
> We should add the ability to specify a custom cgroup path. This is how the documentation
of {{linux-container-executor.cgroups.mount-path}} would look like:
> {noformat}
>     Requested cgroup mount path. Yarn has built in functionality to discover
>     the system cgroup mount paths, so use this setting only, if the discovery does not
work.
>     This path must exist before the NodeManager is launched.
>     The location can vary depending on the Linux distribution in use.
>     Common locations include /sys/fs/cgroup and /cgroup.
>     If cgroups are not mounted, set yarn.nodemanager.linux-container-executor.cgroups.mount
>     to true. In this case it specifies, where the LCE should attempt to mount cgroups
if not found.
>     If cgroups is accessible through lxcfs or some other file system,
>     then set this path and yarn.nodemanager.linux-container-executor.cgroups.mount to
false.
>     Yarn tries to use this path first, before any cgroup mount point discovery.
>     If it cannot find this directory, it falls back to searching for cgroup mount points
in the system.
>     Only used when the LCE resources handler is set to the CgroupsLCEResourcesHandler
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message