hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6593) [API] Introduce Placement Constraint object
Date Thu, 27 Jul 2017 21:45:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103963#comment-16103963
] 

Wangda Tan commented on YARN-6593:
----------------------------------

Thanks [~kkaranasos] for updating the patch, could you check the reported Javadocs warning?

In addition to that, some comments for API annotations:
1) Since we're in the early phase of the feature, instead of marking PlacementConstraint(s)
to be public/evolving, I prefer to mark them to public/unstable.
2) private/evolving is not proper, private should come unstable or empty (Just like CapacitySchedulerConfiguration)
always.
3) Do we really need to mark {{api/resource/package-info.java}} to public? It could accidentally
add {{@public}} classes in the future 
4) A couple of {{static final}} fields in PlacementConstraint(s) should be {{@private}}, for
example: {{PlacementConstraints#NODE/RACK}}.

> [API] Introduce Placement Constraint object
> -------------------------------------------
>
>                 Key: YARN-6593
>                 URL: https://issues.apache.org/jira/browse/YARN-6593
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-6593.001.patch, YARN-6593.002.patch, YARN-6593.003.patch, YARN-6593.004.patch,
YARN-6593.005.patch, YARN-6593.006.patch
>
>
> Just removed Fixed version and moved it to target version as we set fix version only
after patch is committed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message