hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yufei Gu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6505) Define the strings used in SLS JSON input file format
Date Mon, 31 Jul 2017 19:16:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107814#comment-16107814
] 

Yufei Gu commented on YARN-6505:
--------------------------------

Thanks for the new patch. [~GergelyNovak]. Some thoughts:
# It is an incompatible change to add prefix to "duration.ms", which not only breaks existing
tests, but is also verbose. 
# Unnecessary empty line before method {{getAMContainerResource}}
# It's weird that CONTAINER_VCORES refers to two different things. I suggest to change the
name of all task related input configurations to {{TASK_XXX}} instead of {{CONTAINER_XXX}}
since "task" is a more appropriate name and containers could be AM containers or task containers.



> Define the strings used in SLS JSON input file format
> -----------------------------------------------------
>
>                 Key: YARN-6505
>                 URL: https://issues.apache.org/jira/browse/YARN-6505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler-load-simulator
>            Reporter: Yufei Gu
>            Assignee: Gergely Novák
>              Labels: newbie
>         Attachments: YARN-6505.001.patch, YARN-6505.002.patch
>
>
> We could put them in a Java file like what YarnConfiguration does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message