hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6033) Add support for sections in container-executor configuration file
Date Thu, 20 Jul 2017 21:25:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095405#comment-16095405
] 

Wangda Tan commented on YARN-6033:
----------------------------------

[~vvasudev], 

While doing test for YARN-6223 (based on this patch). I think there's a minor change needed:


In "container-executor.c", it has following statement:
{code}
executor_cfg = *(get_configuration_section("", &CFG)));
{code}

However if we have a config file doesn't has key/value under default section, such as an empty
config file, or file like:
{code}
[named-section]
k=v
{code}

The returned value of {{get_configuration_section("", &CFG)}} will be NULL which will
cause process crash without proper error message.

To fix the problem, we can:
1) Set an empty/NULL value to executor_cfg. Probably we should change executor_cfg to a pointer.
2) By default create an empty value (not null) section in struct configuration.

Thoughts?

> Add support for sections in container-executor configuration file
> -----------------------------------------------------------------
>
>                 Key: YARN-6033
>                 URL: https://issues.apache.org/jira/browse/YARN-6033
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-6033.003.patch, YARN-6033.004.patch, YARN-6033-YARN-5673.001.patch,
YARN-6033-YARN-5673.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message