hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlo Curino (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5412) Create a proxy chain for ResourceManager REST API in the Router
Date Mon, 17 Jul 2017 20:57:02 GMT

    [ https://issues.apache.org/jira/browse/YARN-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090538#comment-16090538
] 

Carlo Curino commented on YARN-5412:
------------------------------------


[~giovanni.fumarola], thanks for addressing the feedback. Here some more, based on your latest
patch.

# {{hadoop-yarn-server-router/pom.xml}} can you validate the list you add is minimal and as
narrowly scoped as possible?
# I think that in {{DefaultRequestInterceptorREST}} the implementations of {{getNodes}}, {{getLabelsToNodes}},
{{replaceLabelsOnNode}} don't forward all the inputs correctly 
# Related to the above, your tests should be tighter and attempt to catch these things
# Add comments for the one not-needed as part of HSR
# Why the {{DefaultRequestInterceptorREST}} does not implement {{getAppAttempt, getContainers,
getContainere}}?
# {{RouterWebApp}} what happens if the router is not initialized?  
# {{RouterWebServiceUtil (89}} shouldn't you throw an exception in this case?
# {{RouterWebServiceUtil (105}} is 200 the only "correct" code ever returned? (What about
201/202/204...) Maybe just check is in 2XX series.
# {{RouterWebServices.init()}} the init name is a bit misleading, as it looks more like a
"clearResponse". Also is it enough to set content type to null, to clear?
# {{TestRouterWebServicesREST}} seem to still have a large amount of redundancy in the code,
the same "generics" tricks you played in {{DefaultRequestInterceptorREST}} should apply here
as well.
# {{TestRouterWebServicesREST}} seem to mostly/only? test correct paths. It would be good
to verify also wrong/null inputs and wrong-paths, validating the system catches and throws
correclty in those cases. 
# {{TestRouterWebServicesREST}} it should be easy to make this test parametric, and have it
run with both .jsom an .xml formats (broaden the coverage with little work).

# Please comment on / address the Yetus issues.

> Create a proxy chain for ResourceManager REST API in the Router
> ---------------------------------------------------------------
>
>                 Key: YARN-5412
>                 URL: https://issues.apache.org/jira/browse/YARN-5412
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Giovanni Matteo Fumarola
>         Attachments: YARN-5412-YARN-2915.1.patch, YARN-5412-YARN-2915.2.patch, YARN-5412-YARN-2915.3.patch,
YARN-5412-YARN-2915.4.patch, YARN-5412-YARN-2915.proto.patch
>
>
> As detailed in the proposal in the umbrella JIRA, we are introducing a new component
that routes client request to appropriate ResourceManager(s). This JIRA tracks the creation
of a proxy for ResourceManager REST API in the Router. This provides a placeholder for:
> 1) throttling mis-behaving clients (YARN-1546)
> 3) mask the access to multiple RMs (YARN-3659)
> We are planning to follow the interceptor pattern like we did in YARN-2884 to generalize
the approach and have only dynamically coupling for Federation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message