hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vrushali C (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4455) Support fetching metrics by time range
Date Mon, 17 Jul 2017 23:34:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090796#comment-16090796
] 

Vrushali C commented on YARN-4455:
----------------------------------

Yes, thanks for the patch [~varun_saxena]! 


bq. Primarily used to distinguish between metrics written in flow run table from different
apps. So that we have 2 different puts for different apps and one does not overwrite metric
of other just because the timestamps were same.
yes this is correct.

bq. Not really required for entity and app tables but multiplying it by a factor ensures that
code path is common while writing.
I am wondering if this might be a concern for entity or application tables. When we multiply
the timestamp by TimestampGenerator#TS_MULTIPLIER  , I am wondering if the timestamp meaning
is changing. Also if it will roll over and may not mean the right thing. 

For example, if the metrics data was written with timestamp of today at 3pm, the multiplier
will move it to another timestamp. 

I am reading through the unit tests to see how the metrics are being from hbase in the reader.
I believe it's lines 1745 onwards. Did the number of metrics timeseries 13 come from the inserts
in the prior tests? I am trying to get my head around how the modified timestamp is helping
retrieve metrics. 



> Support fetching metrics by time range
> --------------------------------------
>
>                 Key: YARN-4455
>                 URL: https://issues.apache.org/jira/browse/YARN-4455
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-5355
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: YARN-5355, yarn-5355-merge-blocker
>         Attachments: YARN-4455-YARN-5355.01.patch, YARN-4455-YARN-5355.02.patch, YARN-4455-YARN-5355.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message