hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-2919) Potential race between renew and cancel in DelegationTokenRenwer
Date Thu, 06 Jul 2017 19:10:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077085#comment-16077085

Naganarasimha G R commented on YARN-2919:

May be my understanding is wrong and correct me if i am so. I went more based on the description
which is there in MAPREDUCE-5384 which says the two possible race scenarios. but though one
is correct not completely sure about the second one.
Races to fix:
# TimerTask#cancel() disallows future invocations of run(), but doesn't abort an already scheduled/started
# In the context of DelegationTokenRenewal, RenewalTimerTask#cancel() only cancels that TimerTask
instance. However, it has no effect on any other TimerTasks created for that token.
Attach one or more files to this issue
assume {{RenewalTimerTask. run}} is invoked by the timer task and it has passed through the
{{if (!dttr.isTimerCancelled())}} but before {{renewToken(DelegationTokenToRenew)}} or in
between {{renewToken}} & {{setTimerForTokenRenewal}} is invoked, {{removeApplicationFromRenewal}}
gets triggered. In which case unnecessary renew or timer task scheduling happens
IIUC this is what even Sid meant by ??The in-process renew can check these till the last moment
before invoking the actual renew, and subsequent renewals will not attempt a renew (maybe
even not schedule a renew)?? in his [comment|https://issues.apache.org/jira/browse/MAPREDUCE-5384?focusedCommentId=13745421&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13745421]
in MAPREDUCE-5384.

> Potential race between renew and cancel in DelegationTokenRenwer 
> -----------------------------------------------------------------
>                 Key: YARN-2919
>                 URL: https://issues.apache.org/jira/browse/YARN-2919
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2919.002.patch, YARN-2919.003.patch, YARN-2919.004.patch, YARN-2919.005.patch,
> YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a race because
of which a renewal in flight isn't interrupted by a cancel. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message