hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6678) Committer thread crashes with IllegalStateException in async-scheduling mode of CapacityScheduler
Date Fri, 09 Jun 2017 07:09:18 GMT

    [ https://issues.apache.org/jira/browse/YARN-6678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044063#comment-16044063
] 

Hadoop QA commented on YARN-6678:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  7s{color} | {color:red}
YARN-6678 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-6678 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12870767/YARN-6678.001.patch
|
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/16166/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Committer thread crashes with IllegalStateException in async-scheduling mode of CapacityScheduler
> -------------------------------------------------------------------------------------------------
>
>                 Key: YARN-6678
>                 URL: https://issues.apache.org/jira/browse/YARN-6678
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>    Affects Versions: 2.9.0, 3.0.0-alpha3
>            Reporter: Tao Yang
>            Assignee: Tao Yang
>         Attachments: YARN-6678.001.patch
>
>
> Error log:
> {noformat}
> java.lang.IllegalStateException: Trying to reserve container container_e10_1495599791406_7129_01_001453
for application appattempt_1495599791406_7129_000001 when currently reserved container container_e10_1495599791406_7123_01_001513
on node host: node0123:45454 #containers=40 available=... used=...
>         at org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerNode.reserveResource(FiCaSchedulerNode.java:81)
>         at org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp.reserve(FiCaSchedulerApp.java:1079)
>         at org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp.apply(FiCaSchedulerApp.java:795)
>         at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.tryCommit(CapacityScheduler.java:2770)
>         at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler$ResourceCommitterService.run(CapacityScheduler.java:546)
> {noformat}
> Reproduce this problem:
> 1. nm1 re-reserved app-1/container-X1 and generated reserve proposal-1
> 2. nm2 had enough resource for app-1, un-reserved app-1/container-X1 and allocated app-1/container-X2
> 3. nm1 reserved app-2/container-Y
> 4. proposal-1 was accepted but throw IllegalStateException when applying
> Currently the check code for reserve proposal in FiCaSchedulerApp#accept as follows:
> {code}
>           // Container reserved first time will be NEW, after the container
>           // accepted & confirmed, it will become RESERVED state
>           if (schedulerContainer.getRmContainer().getState()
>               == RMContainerState.RESERVED) {
>             // Set reReservation == true
>             reReservation = true;
>           } else {
>             // When reserve a resource (state == NEW is for new container,
>             // state == RUNNING is for increase container).
>             // Just check if the node is not already reserved by someone
>             if (schedulerContainer.getSchedulerNode().getReservedContainer()
>                 != null) {
>               if (LOG.isDebugEnabled()) {
>                 LOG.debug("Try to reserve a container, but the node is "
>                     + "already reserved by another container="
>                     + schedulerContainer.getSchedulerNode()
>                     .getReservedContainer().getContainerId());
>               }
>               return false;
>             }
>           }
> {code}
> The reserved container on the node of reserve proposal will be checked only for first-reserve
container, not for the re-reserve container.
> I think FiCaSchedulerApp#accept should do this check for all reserve proposal not matter
if the container is re-reserve or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message