hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6674) Add memory cgroup settings for opportunistic containers
Date Thu, 22 Jun 2017 18:33:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059829#comment-16059829
] 

ASF GitHub Bot commented on YARN-6674:
--------------------------------------

Github user szegedim commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/240#discussion_r123589398
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsMemoryResourceHandlerImpl.java
---
    @@ -122,12 +128,23 @@ int getSwappiness() {
           cGroupsHandler.updateCGroupParam(MEMORY, cgroupId,
               CGroupsHandler.CGROUP_PARAM_MEMORY_HARD_LIMIT_BYTES,
               String.valueOf(containerHardLimit) + "M");
    -      cGroupsHandler.updateCGroupParam(MEMORY, cgroupId,
    -          CGroupsHandler.CGROUP_PARAM_MEMORY_SOFT_LIMIT_BYTES,
    -          String.valueOf(containerSoftLimit) + "M");
    -      cGroupsHandler.updateCGroupParam(MEMORY, cgroupId,
    -          CGroupsHandler.CGROUP_PARAM_MEMORY_SWAPPINESS,
    -          String.valueOf(swappiness));
    +      ContainerTokenIdentifier id = container.getContainerTokenIdentifier();
    +      if (id != null && id.getExecutionType() ==
    +          ExecutionType.OPPORTUNISTIC) {
    +        cGroupsHandler.updateCGroupParam(MEMORY, cgroupId,
    +            CGroupsHandler.CGROUP_PARAM_MEMORY_SOFT_LIMIT_BYTES,
    +            String.valueOf(OPPORTUNISTIC_SOFT_LIMIT) + "M");
    +        cGroupsHandler.updateCGroupParam(MEMORY, cgroupId,
    --- End diff --
    
    Swapping may cause issues, yes, however we cannot tell the user to turn it off.


> Add memory cgroup settings for opportunistic containers
> -------------------------------------------------------
>
>                 Key: YARN-6674
>                 URL: https://issues.apache.org/jira/browse/YARN-6674
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Haibo Chen
>            Assignee: Miklos Szegedi
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message